yamt commented on a change in pull request #1340:
URL: https://github.com/apache/incubator-nuttx/pull/1340#discussion_r448167853
##########
File path: arch/arm/src/tms570/tms570_lowputc.c
##########
@@ -272,19 +273,20 @@ void tms570_lowsetup(void)
#endif
}
-/************************************************************************************
+/****************************************************************************
* Name: tms570_sci_configure
*
* Description:
* Configure an SCI for non-interrupt driven operation
*
-
************************************************************************************/
+ ****************************************************************************/
-int tms570_sci_configure(uint32_t base, FAR const struct sci_config_s *config)
+int tms570_sci_configure(uint32_t base,
+ FAR const struct sci_config_s *config)
{
- float32 divb7;
+ float_t divb7;
uint32_t intpart;
Review comment:
isn't it better to use just float in C code?
##########
File path: arch/arm/src/tms570/tms570_lowputc.c
##########
@@ -272,19 +273,20 @@ void tms570_lowsetup(void)
#endif
}
-/************************************************************************************
+/****************************************************************************
* Name: tms570_sci_configure
*
* Description:
* Configure an SCI for non-interrupt driven operation
*
-
************************************************************************************/
+ ****************************************************************************/
-int tms570_sci_configure(uint32_t base, FAR const struct sci_config_s *config)
+int tms570_sci_configure(uint32_t base,
+ FAR const struct sci_config_s *config)
{
- float32 divb7;
+ float_t divb7;
uint32_t intpart;
- float32 frac;
+ float_t frac;
Review comment:
i couldn't find where this variable is used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
