nuttxpr commented on PR #14318: URL: https://github.com/apache/nuttx/pull/14318#issuecomment-2413617512
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not fully meet the NuttX requirements.** **Missing Information:** * **Summary:** * **Functional part:** Which specific file(s) and functions are being modified? * **Exact changes:** Provide more detail on *how* the sample rate and encoding are set and used within the code. * **Impact:** * **User impact:** Will applications need modification to use the expanded sample rate range? * **Build impact:** Are there any configuration options or dependencies introduced? * **Hardware impact:** Specify which architectures (sim, RISC-V, ARM, etc.) and boards were tested. * **Documentation impact:** Does this change require updates to any existing documentation? * **Security, compatibility:** While you may not anticipate issues, briefly address these points (e.g., "No security implications are foreseen."). * **Testing:** * **Build Host details:** Provide specifics about your development environment (OS, compiler version, etc.). * **Target details:** List the exact board and configuration used in the simulator. * **Testing logs:** Include relevant logs from *both* before and after the change to demonstrate the issue and the fix. **Recommendations:** 1. **Expand on the missing details** outlined above to provide a complete picture of the changes. 2. **Use a descriptive PR title** that clearly summarizes the purpose of your changes (e.g., "audio: Expand supported sample rate range beyond 255"). 3. **Consider adding unit tests** to verify the functionality of your changes and prevent regressions. By addressing these points, you will create a PR that is easier for maintainers to review and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
