nuttxpr commented on PR #14306: URL: https://github.com/apache/nuttx/pull/14306#issuecomment-2413361855
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR description seems to meet most of the NuttX requirements, but could use some improvements for clarity and completeness. **Here's a breakdown:** **Strengths:** * **Summary:** You clearly state the problem (unauthorized writes to `cntfrq_el0` register) and the context (system not in EL3 mode). The explanation of potential consequences is helpful. * **Impact:** You correctly identify that the PR fixes an existing issue. **Areas for Improvement:** * **Summary:** * **Functional Part:** Specify the exact code section being modified (e.g., specific file and function). * **How it Works:** Briefly describe the technical approach taken to prevent the unauthorized writes. * **Issue Reference:** If this PR addresses a specific issue in the NuttX issue tracker, provide a link. * **Impact:** * **User Impact:** While you mention it fixes an issue, be explicit if users need to make any changes (likely NO in this case). * **Build/Hardware/Documentation/Security/Compatibility:** Clearly state "NO" for each category if they are not impacted. If any are impacted, provide details as requested in the requirements. * **Testing:** * **Build Hosts:** List the specific operating system, CPU architecture, and compiler used for testing. * **Targets:** Specify the exact architecture (e.g., Cortex-A53) and board:config used with QEMU. * **Testing Logs:** Provide snippets of relevant logs from *before* and *after* the change. These logs should demonstrate the issue and the fix. **Example Additions:** * **Summary:** "This change modifies the `arch/arm/src/armv8-a/cpu_start.c` file within the `arm_cpu_boot()` function. It ensures that writes to the `cntfrq_el0` register are only attempted when the system is confirmed to be operating in EL3 mode, preventing potential instability." * **Testing:** "Build Host: Linux (Ubuntu 20.04), x86-64, GCC 9.3.0. Target: QEMU-virt, Cortex-A53, sim:nsh." **By providing more specific details and demonstrating the impact through testing logs, your PR will be clearer, more informative, and easier to review.** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
