nuttxpr commented on PR #14303: URL: https://github.com/apache/nuttx/pull/14303#issuecomment-2413322808
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not meet the NuttX requirements.** Here's why and how to improve it: **Missing Information in Summary:** * **Why is this change necessary?** * Is it a new feature request? Is there a performance bottleneck with existing AI processing? * **What functional part of the code is changed?** * Be specific. Mention the directory, files added/modified, and the core components affected (e.g., drivers, middleware, kernel). * **How does the change work?** * Provide a technical explanation of the driver's architecture, how it interacts with NPU backends, and any key algorithms or mechanisms used. * **Link to Issues:** * If this addresses an existing issue on either the NuttX or NuttX Apps repositories, provide the links. **Insufficient Impact Assessment:** * **Impact on Hardware:** * You **must** list the specific NPUs (hardware) supported by this driver. * **Impact on Build:** * Does adding this driver introduce new build dependencies? Do users need to enable a specific configuration option? * **Impact on Documentation:** * New drivers *always* require documentation updates. Explain where you've added documentation (e.g., a new page in the drivers section) and what it covers. **Lack of Testing Details:** * **Build Hosts:** * Specify the operating system, architecture, and compiler versions used for development and testing. * **Target(s):** * List the exact target architectures and boards (with configurations) where this driver has been tested. * **Testing Logs:** * Provide *actual* log output showing the driver's behavior before and after your changes. This helps reviewers understand what you tested and how the system behaves. **General Recommendations:** * **Be Thorough:** Address *all* points in the PR template. * **Technical Depth:** Don't be afraid to get technical; reviewers need to understand your implementation. * **Proofread:** Ensure your writing is clear, concise, and free of grammatical errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
