nuttxpr commented on PR #14301: URL: https://github.com/apache/nuttx/pull/14301#issuecomment-2413255042
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) ## PR Requirements Review **Meets Requirements?** Partially **Missing/Incomplete Information:** * **Summary:** * **Why is this change necessary?** You state the technical reason but not the impact. Does incorrect LTPSIZE cause functional issues? Performance problems? * **What functional part is changed?** Be specific. E.g., "ARMv8-M FPU initialization code" * **How does it work?** "Setting LTPSIZE to 0b100 during FPU initialization" is more helpful. * **Impact:** * You ONLY list "fpu" – this is too vague. Consider ALL categories: * **New feature?** Likely NO, but clarify if this enables something previously broken * **User impact?** Probably NO, but state explicitly if any user-facing behavior changes * **Build impact?** Unlikely, but mention if any build options are added/modified * **Hardware impact?** ONLY ARMv8-M systems with FPUs. Be explicit. * **Documentation?** Likely requires an update to mention this setting. * **Security, Compatibility** - Address these even if the answer is NO. * **Testing:** * **Build Hosts:** List ALL used (OS, CPU arch, compiler versions). "bes board" is not a host. * **Targets:** "bes board" is insufficient. Full name, config used. * **Logs:** Provide ACTUAL logs, not just the instruction to do so. **Recommendations:** 1. **Expand on missing details:** Don't assume reviewers have full context. 2. **Be explicit, even for "NO" impacts:** This removes ambiguity. 3. **Provide concrete testing data:** Logs are crucial for verifying the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
