nuttxpr commented on PR #14267:
URL: https://github.com/apache/nuttx/pull/14267#issuecomment-2410867812

   [**\[Experimental Bot, please feedback 
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   __Fill In The Commit Message:__ This PR contains a Commit with an Empty 
Commit Message. Please fill in the Commit Message with the PR Summary.
   
   
   
   The PR summary and impact sections appear to meet NuttX requirements. 
However, the testing section is insufficient. 
   
   Here's what needs improvement:
   
   * **Testing details:**  The provided information is too vague.
       * **Be specific about build hosts:** Specify the exact OS versions, CPU 
architectures, and compiler versions used for testing. For example, "Ubuntu 
20.04, x86_64, GCC 9.4" is much better than just "Linux".
       * **Be specific about target(s):** Clearly list each tested 
architecture, board, and configuration.  Don't just say "ESP32" -  specify 
"ESP32-DevKitC" or similar.
       * **Show actual logs:**  The "Testing logs before/after" sections are 
empty. Include relevant snippets demonstrating the issue before the change and 
the successful outcome after.
   
   **In short,  provide concrete evidence that your change works as intended.** 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to