xiaoxiang781216 commented on code in PR #2697: URL: https://github.com/apache/nuttx-apps/pull/2697#discussion_r1798134402
########## nshlib/nsh.h: ########## @@ -1394,7 +1394,8 @@ int nsh_foreach_direntry(FAR struct nsh_vtbl_s *vtbl, FAR const char *cmd, * ****************************************************************************/ -#if defined(CONFIG_FS_PROCFS) && !defined(CONFIG_NSH_DISABLE_PIDOF) +#if defined(CONFIG_FS_PROCFS) && \ + (!defined(CONFIG_NSH_DISABLE_PIDOF) || !defined(CONFIG_NSH_DISABLE_PKILL)) Review Comment: let's remove `(!defined(CONFIG_NSH_DISABLE_PIDOF) || !defined(CONFIG_NSH_DISABLE_PKILL))`? to avoid the new break in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
