nuttxpr commented on PR #14152: URL: https://github.com/apache/nuttx/pull/14152#issuecomment-2408437784
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR description is **missing crucial information** and does not fully meet the NuttX requirements. Here's a breakdown: **Missing Information:** * **What functional part of the code is being changed?** Be specific. Which files, functions, or modules are modified to correct the `setjmp` behavior? * **How does the change exactly work?** Explain the technical implementation details of the fix. * **Impact on user:** Will any existing applications relying on the incorrect behavior break? How should they adapt? * **Impact on hardware:** While the description mentions "some architectures", it doesn't specify which ones. List the affected architectures explicitly. * **Testing:** * **Incomplete:** "Testing code lives in the nuttx apps repository" is not sufficient. Include relevant snippets of the testing logs demonstrating the issue before and the fix after the change. * **Unclear:** "as a separate patch" is confusing. Is the testing part of this PR or a separate one? If separate, provide a link. * **Links:** Include links to the related NuttX issue and the testing patch in the NuttX Apps repository. **Recommendations:** 1. **Expand the Summary:** Provide specific details about the code changes and their mechanism. 2. **Clarify Impact:** Clearly state the affected architectures and potential user impact (if any). 3. **Complete Testing Section:** Include relevant testing log snippets directly in the PR description. If the testing is a separate patch, provide a link to it. 4. **Add Links:** Include links to the related NuttX and NuttX Apps issues/PRs. By addressing these points, you'll make your PR much stronger and easier for reviewers to understand and approve. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
