nuttxpr commented on PR #14154: URL: https://github.com/apache/nuttx/pull/14154#issuecomment-2408437060
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) ## NuttX PR Requirements Review This PR **does not** meet the NuttX requirements in its current form. Here's why: * **Missing Information:** The Summary, Impact, and Testing sections lack the necessary details. * **Summary:** You need to explain: * Why is this change necessary? What problem does it solve? * What part of the codebase is modified? * How does the change work technically? * Is there a related NuttX issue this PR addresses? * **Impact:** You need to analyze: * Does this add a new feature or change an existing one? * How does it affect users? Will they need to adapt? * Does it impact the build process, supported hardware, documentation, security, or compatibility? * **Testing:** You need to provide: * Details about your testing environment (Host OS, CPU, compiler, Target architecture, board, configuration). * Logs or output from your tests before and after the change to demonstrate the fix. * **Conciseness:** While you are asked to be concise, simply stating "no impact" or "ostest" doesn't provide any valuable information. You need to justify your claims. **Recommendations:** 1. **Expand the Summary:** Clearly articulate the problem, solution, and technical details of your change. 2. **Analyze the Impact:** Carefully consider all potential consequences of your PR and document them thoroughly. 3. **Provide Testing Details:** Include specifics about your testing setup and evidence that your changes work as intended. By addressing these points, your PR will be better aligned with NuttX's contribution guidelines, making it easier for reviewers to understand and accept your changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
