nuttxpr commented on PR #14144: URL: https://github.com/apache/nuttx/pull/14144#issuecomment-2408424680
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR does **not** meet the NuttX requirements. Here's why: **Missing Information** * **Insufficient Summary:** The summary is too brief. It needs to explain: * **Why is this change necessary?** What specific performance problem does this solve? Provide benchmarks or metrics if possible. * **What functional part of the code is changed?** Be specific - mention the `mm_addfreechunk` functions and how they are being inlined. * **How does the change work?** Provide a technical explanation of how inlining these functions leads to a 7% improvement. * **Incomplete Impact Assessment:** * While the impact might be minimal, you should still address each point (user, build, hardware, etc.) with a brief "NO" if it doesn't apply. * The claim of "no impact" might not be entirely true. Inlining can sometimes increase code size, which could be relevant for certain embedded systems. * **Inadequate Testing:** * **Insufficient Detail:** "ostest" is not descriptive enough. Specify the following: * Host OS, CPU architecture, compiler version * Target architecture, board, and configuration * **Missing Logs:** You **must** provide build and runtime logs from both before and after the change. This is crucial for reviewers to understand the impact of your changes. **Recommendations** 1. **Expand the Summary:** Provide a detailed explanation of the problem, solution, and technical implementation. 2. **Thoroughly Address Impact:** Even if there's no impact in most areas, explicitly state it for each category. Justify any potential impact. 3. **Provide Detailed Testing Information:** Clearly describe your testing environment and include the required build and runtime logs. **Remember:** A good PR is thorough, well-documented, and easy for reviewers to understand. Addressing these points will significantly improve your PR and increase its chances of being accepted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
