nuttxpr commented on PR #14137: URL: https://github.com/apache/nuttx/pull/14137#issuecomment-2408330416
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR summary and impact assessment are well-written and informative. However, the testing section could be improved: * **More details on testing:** Simply stating "It can pass in our FS related test cases" is not sufficient. Please provide more specific information about the tests conducted: * **Which test cases exactly?** List the names of the specific test cases you executed. * **How were they run?** Did you use a specific test framework or script? * **Test environment:** Provide details like the board configuration used for sim target testing. * **Logs are missing:** The template requests "Testing logs before change" and "Testing logs after change." Please include relevant snippets from the test output. While a full log might be lengthy, focus on sections demonstrating the change's impact. * **Consider edge cases:** Did you test any scenarios where memory allocation from `fs_heap` might be stressed? This helps ensure the changes don't introduce memory leaks or fragmentation issues. By addressing these points, you'll make it easier for reviewers to understand the extent and thoroughness of your testing, increasing confidence in your changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
