nuttxpr commented on PR #14135: URL: https://github.com/apache/nuttx/pull/14135#issuecomment-2408320006
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) ## NuttX PR Requirement Review While concise, the provided information is insufficient to determine if the PR meets NuttX requirements. **Here's a breakdown of what's missing and how to improve the PR:** **Summary:** * **Insufficient detail:** The summary is too brief. Explain *why* saving registers before syslog is crucial. What kind of information loss occurred before? Be specific about the code modified (e.g., function names, file paths). * **Missing links:** Include links to the related NuttX issue this PR addresses. **Impact:** * **Vague:** "Better chance to catch the root cause" is not quantifiable. Clearly state the benefits. Does this improve debugging specific types of errors? * **Incomplete:** Address *all* impact points: * **New feature? Existing feature change?** * **Build process impact?** * **Hardware impact?** * **Documentation impact? This is very important - if your change needs documentation updates, provide them!** * **Security impact?** * **Compatibility impact?** **Testing:** * **Insufficient environment details:** Provide: * **Build Host:** Full OS version, compiler version (e.g., "Linux Ubuntu 20.04, GCC 9.4.0") * **Target:** Be specific (e.g., "QEMU virt machine, ARMv7-A Cortex-A7") * **Unclear testing steps:** * What is the expected output *before* and *after* the change? * How do the provided GDB commands demonstrate the fix? Explain the significance of the call stack differences. * **Limited testing scope:** * Ideally, test on real hardware, not just QEMU. * Include tests for different scenarios that might trigger the issue. **Overall:** The PR demonstrates effort but lacks the necessary detail and evidence for a thorough review. By addressing the points above, you'll significantly increase the chances of a smooth and quick merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
