nuttxpr commented on PR #14108: URL: https://github.com/apache/nuttx/pull/14108#issuecomment-2406955362
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) ## NuttX PR Requirements Review This PR summary, while providing some information, is **missing key elements** to be considered complete against the NuttX requirements. **Here's a breakdown:** **Summary:** * **Insufficient "Why":** You mention "Fix system crash", which is a good start. However, a more detailed explanation of *why* the crash occurs is needed. What's the underlying issue with `CONFIG_PRIORITY_INHERITANCE=y` and the semaphore configurations that leads to the crash? * **Missing "Functional Part":** You point to specific code lines in the crash log. The summary should state which functional area(s) are being modified (e.g., semaphore priority inheritance mechanism, memory management related to semaphores). * **Unclear "How":** The description only lists configuration options, not how the code itself is changing. Explain the actual code modifications that address the crash. * **Issue References:** Include links to relevant NuttX issues if they exist. This helps with tracking and understanding the context. **Impact:** * **Incomplete:** The impact section is barely filled out. Address *all* the points (user impact, build process, hardware, documentation, security, compatibility). Even if the answer is "NO", briefly state why. **Testing:** * **Insufficient Information:** * Specify the exact host OS, versions (compiler, NuttX), and any relevant build tools. * Clearly list the target architectures and boards tested. * The provided logs are incomplete; they show crash points but not the intended behavior after the fix. Include logs demonstrating the issue is resolved. **Recommendations:** 1. **Expand the Summary:** Explain the root cause of the crash and how your code changes address it. 2. **Complete Impact Assessment:** Consider all aspects listed in the requirements, providing even brief explanations for "NO" impacts. 3. **Detailed Testing Information:** Be specific about your testing environment and provide complete logs showing both the problem and the successful outcome after applying your fix. By addressing these points, you'll make your PR much stronger and easier for reviewers to understand and approve. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
