nuttxpr commented on PR #14016: URL: https://github.com/apache/nuttx/pull/14016#issuecomment-2403763496
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not meet the NuttX requirements.** Here's why and how to improve it: **Missing Information:** * **Summary:** * **Why is this change necessary?** Is "perf tool" a new utility? Is it replacing something else? What problem does it solve? * **What functional part of the code is changed?** Be specific. Is it a new directory/module? Does it modify existing kernel code? * **How does the change work?** What are the technical details of your implementation? * **Impact:** * **"No impact" is rarely true.** Even a new tool has *some* impact. Does it add to the NuttX binary size? Does it require any specific configuration options? * **Consider all categories:** Even if the answer is "NO", briefly state why. For example: "Impact on hardware: NO (This is a purely software-based tool)" * **Testing:** * **Provide details about your build host and target.** * **"perf test" is not informative.** What specific tests did you run? What were the expected outcomes? Show *relevant snippets* of the logs, highlighting the differences before and after your change. **How to Improve:** 1. **Elaborate on the Summary:** Provide a clear, concise explanation of the PR's purpose, the code affected, and the technical approach. 2. **Analyze Impact Thoroughly:** Think through each impact category, even if the answer is "NO". Provide brief justifications. 3. **Detailed Testing:** Include specific information about your testing environment, the tests performed, and clear, concise log snippets demonstrating the change's effect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
