xiaoxiang781216 commented on code in PR #13226:
URL: https://github.com/apache/nuttx/pull/13226#discussion_r1738990136
##########
fs/mnemofs/mnemofs_journal.c:
##########
@@ -655,7 +654,8 @@ int mfs_jrnl_wrlog(FAR struct mfs_sb_s * const sb,
/* Store */
- jrnl_blk = mfs_jrnl_blkidx2blk(sb, MFS_JRNL(sb).log_cblkidx);
+ /* jrnl_blk = mfs_jrnl_blkidx2blk(sb, MFS_JRNL(sb).log_cblkidx); */
Review Comment:
why not remove the unused statement directly
##########
fs/mnemofs/mnemofs_master.c:
##########
@@ -373,9 +372,11 @@ int mfs_mn_move(FAR struct mfs_sb_s * const sb, struct
mfs_ctz_s root,
/* TODO: Move journal. Master blocks are full. */
}
- mblk1 = mfs_jrnl_blkidx2blk(sb, MFS_JRNL(sb).n_blks);
- mblk2 = mfs_jrnl_blkidx2blk(sb, MFS_JRNL(sb).n_blks + 1);
- mn = MFS_MN(sb);
+ /* mblk1 = mfs_jrnl_blkidx2blk(sb, MFS_JRNL(sb).n_blks);
+ * mblk2 = mfs_jrnl_blkidx2blk(sb, MFS_JRNL(sb).n_blks + 1);
Review Comment:
ditto
##########
fs/mnemofs/mnemofs_master.c:
##########
@@ -206,7 +205,9 @@ int mfs_mn_init(FAR struct mfs_sb_s * const sb, const mfs_t
jrnl_blk)
struct mfs_jrnl_log_s log;
mblk1 = mfs_jrnl_blkidx2blk(sb, MFS_JRNL(sb).n_blks);
- mblk2 = mfs_jrnl_blkidx2blk(sb, MFS_JRNL(sb).n_blks + 1);
+
+ /* mblk2 = mfs_jrnl_blkidx2blk(sb, MFS_JRNL(sb).n_blks + 1); */
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
