lupyuen commented on PR #12838: URL: https://github.com/apache/nuttx/pull/12838#issuecomment-2270268740
Sorry @no1wudi I think CONFIG_ARCH_RV_ISA_F and CONFIG_ARCH_RV_ISA_D don't exist: [tools/Rust.defs](https://github.com/apache/nuttx/pull/12838/files#diff-48d942d788df701ac673c83269138184fb14dce32ff91a075d8d74ffc93efc20) ```text ifeq ($(CONFIG_ARCH_RV_ISA_F),y) RUST_ARCHTYPE := $(RUST_ARCHTYPE)f endif ifeq ($(CONFIG_ARCH_RV_ISA_D),y) RUST_ARCHTYPE := $(RUST_ARCHTYPE)d endif ``` In my upcoming PR, I propose to change them to CONFIG_ARCH_FPU and CONFIG_ARCH_DPFPU: [tools/Rust.defs](https://github.com/lupyuen2/wip-nuttx/pull/70/files#diff-48d942d788df701ac673c83269138184fb14dce32ff91a075d8d74ffc93efc20) ```text ifeq ($(CONFIG_ARCH_FPU),y) RUST_ARCHTYPE := $(RUST_ARCHTYPE)f endif ifeq ($(CONFIG_ARCH_DPFPU),y) RUST_ARCHTYPE := $(RUST_ARCHTYPE)d endif ``` My PR will also fix the Rust Build `riscv64gc` for [QEMU RISC-V 64-bit](https://github.com/lupyuen2/wip-nuttx/pull/70). (Which has been broken for a while) I hope you are OK with this. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
