zhhyu7 commented on PR #12688: URL: https://github.com/apache/nuttx/pull/12688#issuecomment-2227388382
> @zhhyu7 I didn't follow: you added support to negative offset, but then you check if it is negative and for it to 0. So why don't stay with unsigned implementation. > > My first thought was that negative offset could introduce vulnerabilities, but then I saw you are checking for negative value. I'm confuse... > > Please explain the issue that this modification solves. Hi @acassis, The ```socket(PF_PACKET, SOCK_RAW)``` may send Layer 2 header information filled under user space, at present, this part of information cannot be copied to the space reserved for ```LL_GUARD_SIZE``` by ```io_data``` through ```devif_send```, even though iob_copyin supports negative offset. I don't have a better idea yet, is there a better modification suggestion for this situation? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
