XuNeo commented on code in PR #12611:
URL: https://github.com/apache/nuttx/pull/12611#discussion_r1663514376
##########
drivers/segger/CMakeLists.txt:
##########
@@ -82,46 +79,20 @@ if(CONFIG_SEGGER_RTT)
list(APPEND RTT_SRCS serial_rtt.c)
endif()
- target_compile_options(RTT PRIVATE -Wno-shadow -Wno-array-bounds)
+ target_compile_options(RTT PRIVATE -Wno-shadow -Wno-pointer-to-int-cast)
target_sources(RTT PRIVATE ${RTT_SRCS})
- target_include_directories(RTT PRIVATE config RTT/RTT)
-
+ target_include_directories(RTT PRIVATE config SystemView/SEGGER)
endif()
if(CONFIG_SEGGER_SYSVIEW)
-
- if(NOT EXISTS ${CMAKE_CURRENT_LIST_DIR}/SystemView)
-
- set(SYSVIEW_VERSION 3.30)
-
- FetchContent_Declare(
- systemview
- DOWNLOAD_NAME "SystemView.zip"
- DOWNLOAD_DIR ${CMAKE_CURRENT_LIST_DIR}
- URL
"https://github.com/SEGGERMicro/SystemView/archive/refs/tags/V${SYSVIEW_VERSION}.zip";
- SOURCE_DIR
- ${CMAKE_CURRENT_LIST_DIR}/SystemView
- BINARY_DIR
- ${CMAKE_BINARY_DIR}/SystemView
- DOWNLOAD_NO_PROGRESS true
- TIMEOUT 30)
-
- FetchContent_GetProperties(systemview)
-
- if(NOT systemview_POPULATED)
- FetchContent_Populate(systemview)
- endif()
- endif()
-
nuttx_add_kernel_library(SystemView)
- target_compile_options(SystemView PRIVATE -Wno-shadow)
-
+ target_compile_options(SystemView PRIVATE -Wno-shadow
+ -Wno-pointer-to-int-cast)
target_sources(SystemView PRIVATE note_sysview.c
- SystemView/SYSVIEW/SEGGER_SYSVIEW.c)
+ SystemView/SEGGER/SEGGER_SYSVIEW.c)
- target_include_directories(
- SystemView PRIVATE ../../sched config RTT/RTT SystemView/SEGGER
- SystemView/SYSVIEW)
+ target_include_directories(SystemView PRIVATE ../../sched config RTT/RTT
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
