leducp commented on PR #12354: URL: https://github.com/apache/nuttx/pull/12354#issuecomment-2114247973
> > @nicolas71640 isn't __builtin_fpclassify and other something specific of GCC? Does it work for other C++ compilers as well? > > The similar code in math.h also reference __builtin_xxx too. > > > @xiaoxiang781216 and @masayuki2009 since you have more experience with C++ on NuttX, could you please take a look? > > My concern is that the code added in cmath is almost same as math.h, could w avoid the duplication? I'm not sure that is possible while following the standard: for instance fpclassify, isfinite or even isinf are defined as macros in C99 while they shall be functions in the std namespace for C++. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
