pkarashchenko commented on code in PR #12044:
URL: https://github.com/apache/nuttx/pull/12044#discussion_r1550497977
##########
arch/risc-v/src/common/espressif/esp_start.c:
##########
@@ -97,8 +97,29 @@
# define IS_DROM(addr) (addr >= SOC_DROM_LOW && addr < SOC_DROM_HIGH)
# define IS_SRAM(addr) (IS_IRAM(addr) || IS_DRAM(addr))
# define IS_MMAP(addr) (IS_IROM(addr) || IS_DROM(addr))
-# define IS_NONE(addr) (!IS_IROM(addr) && !IS_DROM(addr) \
- && !IS_IRAM(addr) && !IS_DRAM(addr) && !IS_PADD(addr))
+# ifdef SOC_RTC_FAST_MEM_SUPPORTED
+# define IS_RTC_FAST_IRAM(addr) \
+ (addr >= SOC_RTC_IRAM_LOW && addr < SOC_RTC_IRAM_HIGH)
+# define IS_RTC_FAST_DRAM(addr) \
+ (addr >= SOC_RTC_DRAM_LOW && addr < SOC_RTC_DRAM_HIGH)
+# else
+# define IS_RTC_FAST_IRAM(addr) 0
+# define IS_RTC_FAST_DRAM(addr) 0
+# endif
+# ifdef SOC_RTC_SLOW_MEM_SUPPORTED
+# define IS_RTC_SLOW_DRAM(addr) \
+ (addr >= SOC_RTC_DATA_LOW && addr < SOC_RTC_DATA_HIGH)
Review Comment:
```suggestion
((addr) >= SOC_RTC_DATA_LOW && (addr) <
SOC_RTC_DATA_HIGH)
```
##########
arch/risc-v/src/common/espressif/esp_start.c:
##########
@@ -97,8 +97,29 @@
# define IS_DROM(addr) (addr >= SOC_DROM_LOW && addr < SOC_DROM_HIGH)
Review Comment:
```suggestion
# define IS_DROM(addr) ((addr) >= SOC_DROM_LOW && (addr) < SOC_DROM_HIGH)
```
##########
arch/risc-v/src/common/espressif/esp_start.c:
##########
@@ -97,8 +97,29 @@
# define IS_DROM(addr) (addr >= SOC_DROM_LOW && addr < SOC_DROM_HIGH)
# define IS_SRAM(addr) (IS_IRAM(addr) || IS_DRAM(addr))
# define IS_MMAP(addr) (IS_IROM(addr) || IS_DROM(addr))
-# define IS_NONE(addr) (!IS_IROM(addr) && !IS_DROM(addr) \
- && !IS_IRAM(addr) && !IS_DRAM(addr) && !IS_PADD(addr))
+# ifdef SOC_RTC_FAST_MEM_SUPPORTED
+# define IS_RTC_FAST_IRAM(addr) \
+ (addr >= SOC_RTC_IRAM_LOW && addr < SOC_RTC_IRAM_HIGH)
Review Comment:
```suggestion
((addr) >= SOC_RTC_IRAM_LOW && (addr) <
SOC_RTC_IRAM_HIGH)
```
##########
arch/risc-v/src/common/espressif/esp_start.c:
##########
@@ -97,8 +97,29 @@
# define IS_DROM(addr) (addr >= SOC_DROM_LOW && addr < SOC_DROM_HIGH)
# define IS_SRAM(addr) (IS_IRAM(addr) || IS_DRAM(addr))
# define IS_MMAP(addr) (IS_IROM(addr) || IS_DROM(addr))
-# define IS_NONE(addr) (!IS_IROM(addr) && !IS_DROM(addr) \
- && !IS_IRAM(addr) && !IS_DRAM(addr) && !IS_PADD(addr))
+# ifdef SOC_RTC_FAST_MEM_SUPPORTED
+# define IS_RTC_FAST_IRAM(addr) \
+ (addr >= SOC_RTC_IRAM_LOW && addr < SOC_RTC_IRAM_HIGH)
+# define IS_RTC_FAST_DRAM(addr) \
+ (addr >= SOC_RTC_DRAM_LOW && addr < SOC_RTC_DRAM_HIGH)
Review Comment:
```suggestion
((addr) >= SOC_RTC_DRAM_LOW && (addr) <
SOC_RTC_DRAM_HIGH)
```
##########
arch/risc-v/src/common/espressif/esp_start.c:
##########
@@ -97,8 +97,29 @@
# define IS_DROM(addr) (addr >= SOC_DROM_LOW && addr < SOC_DROM_HIGH)
# define IS_SRAM(addr) (IS_IRAM(addr) || IS_DRAM(addr))
# define IS_MMAP(addr) (IS_IROM(addr) || IS_DROM(addr))
-# define IS_NONE(addr) (!IS_IROM(addr) && !IS_DROM(addr) \
- && !IS_IRAM(addr) && !IS_DRAM(addr) && !IS_PADD(addr))
+# ifdef SOC_RTC_FAST_MEM_SUPPORTED
+# define IS_RTC_FAST_IRAM(addr) \
+ (addr >= SOC_RTC_IRAM_LOW && addr < SOC_RTC_IRAM_HIGH)
+# define IS_RTC_FAST_DRAM(addr) \
+ (addr >= SOC_RTC_DRAM_LOW && addr < SOC_RTC_DRAM_HIGH)
+# else
+# define IS_RTC_FAST_IRAM(addr) 0
Review Comment:
Optional: would be good to `#include <stdbool.h>` and define this to `false`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
