btashton commented on pull request #1160: URL: https://github.com/apache/incubator-nuttx/pull/1160#issuecomment-636550099
> > @patacongo I also wired in the check for nxstyle so we can now get in-line annotations like this, but I needed to make `checkpatch.sh` provide the full path instead of relative. Do you think that this should be handled via an environment variable/flag or is it fine to just make this the default behaviour? I don't really have an opinion on it. > > I don't have any strong opinion. nxstyle does not require an absolute path. It works fine with relative paths, but they have to be relative to the current working directory. Could you have a current working directory problem? Otherwise, I would defer to @xiaoxiang781216 or @liuguo09 since checkpatch.sh is their work. The issue is that nxstyle spits something out like `./include/arch/arch.h:140:0: error: an error` because it is given a relative path github cannot map this back to the proper file. For relative paths to work with the matcher we would have had to check the repo out in the root of the workspace which is not really a good option. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
