patacongo commented on pull request #1157: URL: https://github.com/apache/incubator-nuttx/pull/1157#issuecomment-636529891
> > > @patacongo @xiaoxiang781216 Would you be open to a patch that causes `testbuild.sh` to echo out the error stats in a github actions format that allows for annotating the build with the actual errors instead of having to dig for them in the logs (especially with parallel runs)? I know we want to keep the CI stuff out of this as much as possible, but this would be just some extra a little syntax around the message that github is able to pick up. > We can also define our out syntax and have github understand that, but I dont think it gains us much. > See this https://help.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-a-warning-message This is probably the wrong place to be having this discussion. I am pretty open to changes to testbuild.sh. There are only two "brick walls" that we must not cross: 1. testbuild.sh is a stand-alone program used by many people in their own test environments. It is not inherently a part of the CI build tools; it is only used by the CI build tools. No changes to testbuild.sh must effect the usability for people who use testbuild.sh in their own non-github, non-CI environment for testing. 2. I can't include in unconditional logic that depends on GIT. It must be usable by the many NuttX users (the majority I think), who use their own CM which may or many not be GIT. We must not break that. Having said that, any of the above may be circumvented by simply adding command line parameters that are used only in the NuttX CI build. If those parameters are not present, the legacy behavior is retained and no NuttX user is impacted. There should be no change in the experience for those users who have build their own test harnesses around testbuild.sh. There are already such specialized command line settings. This one: -G Use "git clean -xfdq" instead of "make distclean" to clean the tree. This option may speed up the builds. However, note that: * This assumes that your trees are git based. * This assumes that only nuttx and apps repos need to be cleaned. * If the tree has files not managed by git, they will be removed as well. If the changes that you want to make to testbuild.sh for CI usage diverge too much from the end-user expectation, we should consider an alternative version, perhaps in incubator-nuttx-testing that does not have these necessary restrictions. Re-using code is a good thing. But this is not such complex code that the sharing argument justifies an overly complex tool or a tool that cannot meet both needs. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
