anchao commented on code in PR #11711:
URL: https://github.com/apache/nuttx/pull/11711#discussion_r1493770346


##########
tools/mkdeps.c:
##########
@@ -81,12 +81,12 @@
  * Private Types
  ****************************************************************************/
 
-enum slashmode_e
+typedef enum
 {
-  MODE_FSLASH  = 0,
-  MODE_BSLASH  = 1,
-  MODE_DBLBACK = 2
-};
+  TOOLCHAIN_GNU      = 0,

Review Comment:
   emm... consider whether it is inappropriate to decide on behavior during 
compilation? If the toolchain is changed after first configure



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to