leducp commented on code in PR #11415: URL: https://github.com/apache/nuttx/pull/11415#discussion_r1465281608
########## tools/toolchain.cmake.export: ########## @@ -1,5 +1,6 @@ set(CMAKE_SYSTEM_NAME Generic) set(CMAKE_SYSTEM_VERSION 1) +set(NUTTX 1) Review Comment: I think full uppercase is better because it follows CMake style: if you look in ```/usr/share/cmake-xx/Modules/Platform```, you can see that all OS variables are set with uppercase only (i.e. BeOS -> BEOS, Android -> ANDROID, SerenityOS -> SERENITYOS, and so on). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
