w2016561536 commented on code in PR #11575:
URL: https://github.com/apache/nuttx/pull/11575#discussion_r1462235321
##########
arch/xtensa/src/esp32s3/esp32s3_spi.c:
##########
@@ -1312,22 +1337,23 @@ void esp32s3_spi_dma_init(struct spi_dev_s *dev)
{
struct esp32s3_spi_priv_s *priv = (struct esp32s3_spi_priv_s *)dev;
- /* Enable GDMA clock for the SPI peripheral */
-
- modifyreg32(SYSTEM_PERIP_CLK_EN0_REG, 0, priv->config->dma_clk_bit);
-
- /* Reset GDMA for the SPI peripheral */
-
- modifyreg32(SYSTEM_PERIP_RST_EN0_REG, priv->config->dma_rst_bit, 0);
-
Review Comment:
> Please, revert your changes and keep the overall device initialization.
OK. I trust you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
