yf13 commented on code in PR #11542:
URL: https://github.com/apache/nuttx/pull/11542#discussion_r1451846126


##########
sched/task/task_activate.c:
##########
@@ -94,4 +94,11 @@ void nxtask_activate(FAR struct tcb_s *tcb)
     }
 
   leave_critical_section(flags);
+

Review Comment:
   Yes it maybe switched out thus the log comes late. it is fine if meaning of 
this log is "task is already activated". It is at current location if we want 
it to tell a fact, not possiblity.  doing it at line 86 could be fine, though 
the log tells a possibility.
   
   I am fine with both though, please let me know your suggestion. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to