yamt commented on PR #11474: URL: https://github.com/apache/nuttx/pull/11474#issuecomment-1876976696
> > > > > please add a commit message and sign your commit > > > > > > > > > > > > signed-off-by is a linux thing, not ours, as far as i know. > > > > > > > > > does not look signed please use > > > git commit -sm"message to be added > > > body for the message " > > > > > > have we mandated to use -s? why? do we have DCO-style doc? > > i don't see why you request multi-line commit messages for super simple patches like this. > > -s adds signature to your patch and signig your patches is a good practice not a linux thing a commit without project's definition of it, signed-off-by is meaningless, as far as i understand. linux has its definition somewhere under their Documenatation. if you want to make us follow it, i don't necessarily object. > message should have a title and a body no matter if it is a small or huge patch i agree small/huge doesn't matter. what actually matters is simple/complex. > > nothing is enforced, it as just a wish -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
