sebastianene07 commented on a change in pull request #1009:
URL: https://github.com/apache/incubator-nuttx/pull/1009#discussion_r422860265



##########
File path: arch/sim/src/sim/up_oneshot.c
##########
@@ -357,6 +358,16 @@ FAR struct oneshot_lowerhalf_s *oneshot_initialize(int 
chan,
 
 void up_timer_initialize(void)
 {
+  /* Block the signals for the new threads created on the host to prevent
+   * a race condition where the simulated interrupt handler runs on another
+   * host thread. The new threads will inherit the signal mask which has
+   * blocked signals.
+   */
+
+#ifdef CONFIG_SIM_PREEMPTIBLE
+  up_prepare_timer();

Review comment:
       Thanks for the suggestion, ```up_oneshot.c``` is part of the CSRCS list 
and it's using the NuttX API. My timer is using the host timer and it builds in 
the HOSTSRC list. I am not sure if merging them it's ok. What do you think ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to