xiaoxiang781216 commented on a change in pull request #1009:
URL: https://github.com/apache/incubator-nuttx/pull/1009#discussion_r422496321
##########
File path: arch/sim/src/sim/up_idle.c
##########
@@ -89,6 +89,15 @@ void up_idle(void)
}
#endif
+#ifndef CONFIG_SIM_PREEMPTIBLE
+ /* If the system is idle, then process "fake" timer interrupts.
+ * Hopefully, something will wake up.
+ */
+
+ nxsched_process_timer();
Review comment:
Yes, but if you support tickless, you should deliver the timer interrupt
according OS request. Now you generate the timer interrupt at a fixed interval.
Here is more info you can reference:
https://cwiki.apache.org/confluence/display/NUTTX/NuttX+Simulation
That's why I suggest you don't add your own timer implementation, the right
thing is enhancing up_oneshot.c which already support both fixed tick and
variable tick.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
