davids5 commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx URL: https://github.com/apache/incubator-nuttx/pull/745#discussion_r408217514
########## File path: arch/arm/include/stm32h7/chip.h ########## @@ -53,16 +53,40 @@ * * PART PACKAGE * ----------- ---------------- + * STM32H7x3Ax UFBGA169 Review comment: I think the CONFIG_STM32H7_HAVE_GPIOx solution is good way to go, but to catch it at compile time, the CONFIG_STM32H7_HAVE_GPIOx will have to wrapped in the #if defined(CONFIG_STM32H7_HAVE_GPIOx). From the run time side, the table could be set to null and an error returned. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
