This is an automated email from the ASF dual-hosted git repository. hboutemy pushed a commit to branch feature/throw-uoe-for-multipagesinkfactory-createSink-3.x in repository https://gitbox.apache.org/repos/asf/maven-site-plugin.git
commit 653bb5feeb604f7671b54ede87265ccb106628db Author: Konrad Windszus <[email protected]> AuthorDate: Fri Feb 20 20:29:37 2026 +0100 Throw UOE for unsupported MultiPageSinkFactory.createSink(...) overloads This prevent NPE which was previously experienced due to non-allowed null value being returned. This closes #1231 --- .../plugins/site/render/ReportDocumentRenderer.java | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/main/java/org/apache/maven/plugins/site/render/ReportDocumentRenderer.java b/src/main/java/org/apache/maven/plugins/site/render/ReportDocumentRenderer.java index 26f04ec9..5353e770 100644 --- a/src/main/java/org/apache/maven/plugins/site/render/ReportDocumentRenderer.java +++ b/src/main/java/org/apache/maven/plugins/site/render/ReportDocumentRenderer.java @@ -146,21 +146,21 @@ public class ReportDocumentRenderer implements DocumentRenderer { } @Override - public Sink createSink(File arg0, String arg1, String arg2) throws IOException { - // Not used - return null; + public Sink createSink(File outputDir, String outputName, String encoding) throws IOException { + throw new UnsupportedOperationException( + "Only createSink(File, String) is supported by MultiPageSinkFactory. The encoding is always determined by the site rendering context."); } @Override - public Sink createSink(OutputStream arg0) throws IOException { - // Not used - return null; + public Sink createSink(OutputStream out) throws IOException { + throw new UnsupportedOperationException( + "Only createSink(File, String) is supported by MultiPageSinkFactory. OutputStream based sinks are not supported."); } @Override - public Sink createSink(OutputStream arg0, String arg1) throws IOException { - // Not used - return null; + public Sink createSink(OutputStream out, String encoding) throws IOException { + throw new UnsupportedOperationException( + "Only createSink(File, String) is supported by MultiPageSinkFactory. OutputStream based sinks are not supported."); } public List<MultiPageSubSink> sinks() {
