This is an automated email from the ASF dual-hosted git repository.
xxyu pushed a commit to branch kylin5
in repository https://gitbox.apache.org/repos/asf/kylin.git
The following commit(s) were added to refs/heads/kylin5 by this push:
new 975adaad2b KYLIN-5299 fix save basic settings with irrelevant
information
975adaad2b is described below
commit 975adaad2b7dabd130bb0526c64017af9c1e5ead
Author: Mukvin <[email protected]>
AuthorDate: Wed Nov 23 14:45:55 2022 +0800
KYLIN-5299 fix save basic settings with irrelevant information
---
.../setting/SettingBasic/SettingBasic.vue | 33 ++--------------------
1 file changed, 3 insertions(+), 30 deletions(-)
diff --git a/kystudio/src/components/setting/SettingBasic/SettingBasic.vue
b/kystudio/src/components/setting/SettingBasic/SettingBasic.vue
index 04ab9ebf16..0030282513 100644
--- a/kystudio/src/components/setting/SettingBasic/SettingBasic.vue
+++ b/kystudio/src/components/setting/SettingBasic/SettingBasic.vue
@@ -303,7 +303,7 @@ export default class SettingBasic extends Vue {
@Watch('project', { deep: true })
@Watch('rulesObj', { deep: true })
onFormChange () {
- const basicSetting = this.isFormEdited(this.form, 'basic-info') ||
this.isFormEdited(this.form, 'datasource-info') || this.isFormEdited(this.form,
'segment-settings') || this.isFormEdited(this.form, 'storage-quota')
+ const basicSetting = this.isFormEdited(this.form, 'basic-info') ||
this.isFormEdited(this.form, 'datasource-info') || this.isFormEdited(this.form,
'segment-settings')
this.$emit('form-changed', { basicSetting })
}
initForm () {
@@ -358,35 +358,8 @@ export default class SettingBasic extends Vue {
switch (type) {
case 'basic-info': {
const submitData = _getProjectGeneralInfo(this.form)
- if (!submitData.semi_automatic_mode) {
- await this.callGlobalDetailDialog({
- msg: this.$t('turnOffTips'),
- title: this.$t('turnOff') + this.$t('enableSemiAutomatic'),
- dialogType: 'warning',
- isBeta: false,
- wid: '600px',
- showDetailBtn: false,
- dangerouslyUseHTMLString: true,
- needConcelReject: true,
- submitText: this.$t('confirmClose')
- })
- await this.updateProjectGeneralInfo(submitData); break
- } else {
- await this.callGlobalDetailDialog({
- msg: this.$t('turnOnTips'),
- title: this.$t('turnOn') + this.$t('enableSemiAutomatic'),
- dialogType: 'warning',
- isBeta: false,
- wid: '400px',
- isCenterBtn: true,
- showDetailBtn: false,
- dangerouslyUseHTMLString: true,
- needConcelReject: true,
- submitText: this.$t('confirmOpen')
- })
- await this.updateProjectGeneralInfo(submitData)
- break
- }
+ await this.updateProjectGeneralInfo(submitData)
+ break
}
case 'datasource-info': {
if (!this.form.JDBCConnectSetting.length) return errorCallback()