This is an automated email from the ASF dual-hosted git repository.
hulk pushed a commit to branch unstable
in repository https://gitbox.apache.org/repos/asf/kvrocks.git
The following commit(s) were added to refs/heads/unstable by this push:
new fa5f77f15 chore: remove ghproxy option in x.py (#2991)
fa5f77f15 is described below
commit fa5f77f1500c79f414c9bdfdaa9580ce3a1a8cb9
Author: Twice <[email protected]>
AuthorDate: Fri May 23 13:21:57 2025 +0800
chore: remove ghproxy option in x.py (#2991)
Signed-off-by: PragmaTwice <[email protected]>
Co-authored-by: hulk <[email protected]>
---
README.md | 3 +--
x.py | 6 +-----
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/README.md b/README.md
index a6182266a..5f666e80f 100644
--- a/README.md
+++ b/README.md
@@ -80,8 +80,7 @@ It is as simple as:
```shell
$ git clone https://github.com/apache/kvrocks.git
$ cd kvrocks
-$ ./x.py build # `./x.py build -h` to check more options;
- # especially, `./x.py build --ghproxy` will fetch dependencies
via ghproxy.com.
+$ ./x.py build # `./x.py build -h` to check more options
```
To build with TLS support, you'll need OpenSSL development libraries (e.g.
libssl-dev on Debian/Ubuntu) and run:
diff --git a/x.py b/x.py
index deb3b4523..9caf09f09 100755
--- a/x.py
+++ b/x.py
@@ -113,7 +113,7 @@ def prepare() -> None:
dst.symlink_to(hook)
print(f"{hook.name} installed at {dst}.")
-def build(dir: str, jobs: Optional[int], ghproxy: bool, ninja: bool, unittest:
bool, compiler: str, cmake_path: str, D: List[str],
+def build(dir: str, jobs: Optional[int], ninja: bool, unittest: bool,
compiler: str, cmake_path: str, D: List[str],
skip_build: bool) -> None:
basedir = Path(__file__).parent.absolute()
@@ -129,8 +129,6 @@ def build(dir: str, jobs: Optional[int], ghproxy: bool,
ninja: bool, unittest: b
os.makedirs(dir, exist_ok=True)
cmake_options = ["-DCMAKE_BUILD_TYPE=RelWithDebInfo"]
- if ghproxy:
- cmake_options.append("-DDEPS_FETCH_PROXY=https://mirror.ghproxy.com/";)
if ninja:
cmake_options.append("-G Ninja")
if compiler == 'gcc':
@@ -387,8 +385,6 @@ if __name__ == '__main__':
parser_build.add_argument('dir', metavar='BUILD_DIR', nargs='?',
default='build',
help="directory to store cmake-generated and
build files")
parser_build.add_argument('-j', '--jobs', metavar='N', help='execute N
build jobs concurrently')
- parser_build.add_argument('--ghproxy', default=False, action='store_true',
- help='use https://mirror.ghproxy.com to fetch
dependencies')
parser_build.add_argument('--ninja', default=False, action='store_true',
help='use Ninja to build kvrocks')
parser_build.add_argument('--unittest', default=False,
action='store_true', help='build unittest target')
parser_build.add_argument('--compiler', default='auto', choices=('auto',
'gcc', 'clang'),
