RangerRick commented on PR #1804:
URL: https://github.com/apache/karaf/pull/1804#issuecomment-1856367671
> So as far as my understanding goes, we want to structure this just as
features -- i.e. there is feature.core and features.command -- and the latter
is installed conditionally based on the shell feature (IIRC, but a quick grep
should confirm that).
So I'm struggling to understand what feature to put that _in_ though. My
thought was to do this:
```diff
diff --git a/assemblies/features/standard/src/main/feature/feature.xml
b/assemblies/features/standard/src/main/feature/feature.xml
index 85e9e04ce0..96c8fcd180 100644
--- a/assemblies/features/standard/src/main/feature/feature.xml
+++ b/assemblies/features/standard/src/main/feature/feature.xml
@@ -527,2 +527,7 @@ watch = admin
<feature name="config" description="Provide OSGi ConfigAdmin support"
version="${project.version}">
+ <bundle
start-level="11">mvn:org.apache.karaf.config/org.apache.karaf.config.core/${project.version}</bundle>
+ <conditional>
+ <condition>shell</condition>
+ <bundle
start-level="30">mvn:org.apache.karaf.config/org.apache.karaf.config.command/${project.version}</bundle>
+ </conditional>
<conditional>
diff --git a/itests/test/src/test/filtered-resources/etc/feature.xml
b/itests/test/src/test/filtered-resources/etc/feature.xml
index 7926d51995..a334e9d2c7 100644
--- a/itests/test/src/test/filtered-resources/etc/feature.xml
+++ b/itests/test/src/test/filtered-resources/etc/feature.xml
@@ -360,3 +360,6 @@
<bundle start-level="11"
start="true">mvn:org.apache.karaf.config/org.apache.karaf.config.core/${project.version}</bundle>
- <bundle start-level="30"
start="true">mvn:org.apache.karaf.config/org.apache.karaf.config.command/${project.version}</bundle>
+ <conditional>
+ <condition>shell</condition>
+ <bundle start-level="30"
start="true">mvn:org.apache.karaf.config/org.apache.karaf.config.command/${project.version}</bundle>
+ </conditional>
<conditional>
```
...does that seem reasonable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
