This is an automated email from the ASF dual-hosted git repository.
jamesbognar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/juneau.git
The following commit(s) were added to refs/heads/master by this push:
new f855dbcc5a TODO-268 follow-up: strip remaining tracker references in 3
test files
f855dbcc5a is described below
commit f855dbcc5a7e14a0baaea2a575b02ce3d9350b2f
Author: James Bognar <[email protected]>
AuthorDate: Thu Jul 23 10:17:19 2026 -0400
TODO-268 follow-up: strip remaining tracker references in 3 test files
Closes out 3 files held back from the main comment-stripping sweep
(3ab2d1e856) because they mixed comment strips with test string-literal
rewords (a @DisplayName and two assertion failure-message strings):
- BeanInstantiator_Test.java: drop "(TODO-143 Option D)" from a
@DisplayName and "under FINISHED-143 Option D" from a comment.
- Value_StableFolding_Test.java: drop "(per RD #10)" / "(RD #10
caveat)" references from javadoc/comments and from an assertFalse
failure message.
- Settings_NoLeakedSources_Test.java: drop "FINISHED-79" references
from comments and from an assertEquals failure message.
Only human-readable comment/display/message text changed; no asserted
values or executable logic were touched.
Co-authored-by: Cursor <[email protected]>
---
.../org/apache/juneau/commons/inject/BeanInstantiator_Test.java | 4 ++--
.../apache/juneau/commons/inject/Value_StableFolding_Test.java | 8 ++++----
.../apache/juneau/rest/server/Settings_NoLeakedSources_Test.java | 6 +++---
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git
a/juneau-core/juneau-commons/src/test/java/org/apache/juneau/commons/inject/BeanInstantiator_Test.java
b/juneau-core/juneau-commons/src/test/java/org/apache/juneau/commons/inject/BeanInstantiator_Test.java
index 4b38b93525..c56e213ea4 100644
---
a/juneau-core/juneau-commons/src/test/java/org/apache/juneau/commons/inject/BeanInstantiator_Test.java
+++
b/juneau-core/juneau-commons/src/test/java/org/apache/juneau/commons/inject/BeanInstantiator_Test.java
@@ -4589,11 +4589,11 @@ class BeanInstantiator_Test extends TestBase {
}
@Test
- @DisplayName("W09 - Supertype-only parent inner builder loses
to the subtype's direct constructor (TODO-143 Option D)")
+ @DisplayName("W09 - Supertype-only parent inner builder loses
to the subtype's direct constructor")
void w09_builderInParentClass() {
// W_BeanWithParentInnerBuilder has no declared
@Builder, no static factory, and no inner class of
// its own. Priority 3c does find
W_BeanWithInnerBuilder.Builder on the parent, BUT that builder's
- // build() only promises the *supertype*
W_BeanWithInnerBuilder. Under FINISHED-143 Option D a
+ // build() only promises the *supertype*
W_BeanWithInnerBuilder. A
// supertype-only builder candidate must not displace a
usable direct constructor on the more-specific
// requested type, so selection is declined in favor of
the no-arg constructor. (Previously the
// parent-only builder was reported as discovered even
though its output — a parent instance — was
diff --git
a/juneau-core/juneau-commons/src/test/java/org/apache/juneau/commons/inject/Value_StableFolding_Test.java
b/juneau-core/juneau-commons/src/test/java/org/apache/juneau/commons/inject/Value_StableFolding_Test.java
index 1ac6e10472..98fbcb0844 100644
---
a/juneau-core/juneau-commons/src/test/java/org/apache/juneau/commons/inject/Value_StableFolding_Test.java
+++
b/juneau-core/juneau-commons/src/test/java/org/apache/juneau/commons/inject/Value_StableFolding_Test.java
@@ -24,7 +24,7 @@ import org.junit.jupiter.api.*;
import org.junit.jupiter.api.parallel.*;
/**
- * Phase G regression: verifies that stable-folded {@link Var}s (per RD #10)
inside
+ * Phase G regression: verifies that stable-folded {@link Var}s inside
* {@code @Value} expressions fold to a literal at compile time, so subsequent
bean
* constructions read the cached literal text with no runtime dispatch.
*
@@ -55,7 +55,7 @@ class Value_StableFolding_Test extends TestBase {
assertTrue(t.isLiteral(),
"$S{...} with SystemPropertiesVar opts-in to stable
folding — template should be literal after compile");
- // Mutate the property AFTER compile — folded value is frozen
(RD #10 caveat).
+ // Mutate the property AFTER compile — folded value is frozen.
System.setProperty("Value_StableFolding_Test.sysprop",
"barney");
var bean = BeanInstantiator.of(SysPropBean.class, new
BasicBeanStore(null)).run();
assertEquals("fred", bean.value,
@@ -68,10 +68,10 @@ class Value_StableFolding_Test extends TestBase {
}
@Test void a03_propertyVarDoesNotFold_dynamicReads() {
- // PropertyVar stays unstable per RD #10 — Settings can be
updated at runtime, so the
+ // PropertyVar stays unstable — Settings can be updated at
runtime, so the
// @Value("${key}") form must NOT fold at compile time.
var t =
ValueResolver.getCompiledTemplate("${Value_StableFolding_Test.dynamic:default}");
assertFalse(t.isLiteral(),
- "PropertyVar (the ${...} shortcut) is unstable per RD
#10; template must not fold to literal");
+ "PropertyVar (the ${...} shortcut) is unstable;
template must not fold to literal");
}
}
diff --git
a/juneau-integration-tests/src/test/java/org/apache/juneau/rest/server/Settings_NoLeakedSources_Test.java
b/juneau-integration-tests/src/test/java/org/apache/juneau/rest/server/Settings_NoLeakedSources_Test.java
index f7381abf2f..10390899a0 100644
---
a/juneau-integration-tests/src/test/java/org/apache/juneau/rest/server/Settings_NoLeakedSources_Test.java
+++
b/juneau-integration-tests/src/test/java/org/apache/juneau/rest/server/Settings_NoLeakedSources_Test.java
@@ -30,7 +30,7 @@ import org.junit.jupiter.api.*;
* 6.7× full-suite slowdown during an earlier prototype.
*
* <p>
- * In FINISHED-79, an earlier draft of @Rest(config=...) bridging registered a
+ * In an earlier draft, @Rest(config=...) bridging registered a
* {@code ConfigPropertySource} per resolved RestContext via {@code
Settings.get().addSource(...)}.
* MockRestClient statically caches RestContext instances and never invokes
{@code destroy()},
* so the global {@code Settings} source list grew unbounded across the test
suite — a 6.7x
@@ -122,7 +122,7 @@ class Settings_NoLeakedSources_Test extends TestBase {
@Test void a03_twoHundredInstantiations_zeroNewSources() {
var before = Settings.get().sourceCount();
// 200 builds = 10 base classes × 10 builds × 2 mixes (config +
no-config) = matches the
- // FINISHED-79 cache-saturation threshold that produced the
6.7x regression.
+ // cache-saturation threshold that produced the 6.7x regression.
for (var i = 0; i < 10; i++) {
for (var c : NO_CONFIG_CLASSES)
MockRestClient.build(c);
@@ -131,6 +131,6 @@ class Settings_NoLeakedSources_Test extends TestBase {
}
var after = Settings.get().sourceCount();
assertEquals(before, after,
- "After 200 @Rest builds, Settings.get() source list
must not grow (FINISHED-79 regression guard).");
+ "After 200 @Rest builds, Settings.get() source list
must not grow (regression guard).");
}
}
