(juneau) branch master updated: fix: suppress Eclipse ownership/resource warnings in JavaHttpTransport factories and response flow

[jamesbognar]

This is an automated email from the ASF dual-hosted git repository.

jamesbognar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/juneau.git


The following commit(s) were added to refs/heads/master by this push:
     new 0d07d50e9b fix: suppress Eclipse ownership/resource warnings in 
JavaHttpTransport factories and response flow
0d07d50e9b is described below

commit 0d07d50e9b862abc10a7105f1cdd19000e350e64
Author: James Bognar <james.bog...@jamesbog-ltmjqf2.internal.salesforce.com>
AuthorDate: Tue May 19 11:45:06 2026 -0400

    fix: suppress Eclipse ownership/resource warnings in JavaHttpTransport 
factories and response flow
---
 .../org/apache/juneau/rest/client/JavaHttpTransport.java   | 14 ++++++--------
 .../juneau/rest/client/JavaHttpTransportBuilder.java       |  1 +
 .../juneau/rest/client/JavaHttpTransportProvider.java      |  1 +
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git 
a/juneau-rest/juneau-rest-client/src/main/java/org/apache/juneau/rest/client/JavaHttpTransport.java
 
b/juneau-rest/juneau-rest-client/src/main/java/org/apache/juneau/rest/client/JavaHttpTransport.java
index 765127adfc..20a7935357 100644
--- 
a/juneau-rest/juneau-rest-client/src/main/java/org/apache/juneau/rest/client/JavaHttpTransport.java
+++ 
b/juneau-rest/juneau-rest-client/src/main/java/org/apache/juneau/rest/client/JavaHttpTransport.java
@@ -69,18 +69,15 @@ public final class JavaHttpTransport implements 
HttpTransport {
         *
         * @return A new instance. Never <jk>null</jk>.
         */
+       @SuppressWarnings("resource")
        public static JavaHttpTransport create() {
                return builder().build();
        }
 
        @Override /* HttpTransport */
+       @SuppressWarnings("resource")
        public TransportResponse execute(TransportRequest request) throws 
TransportException {
-               HttpRequest jdkRequest;
-               try {
-                       jdkRequest = buildJdkRequest(request);
-               } catch (IOException e) {
-                       throw new TransportException("Failed to build HTTP 
request: " + e.getMessage(), e);
-               }
+               var jdkRequest = buildJdkRequest(request);
                HttpResponse<InputStream> jdkResponse;
                try {
                        jdkResponse = httpClient.send(jdkRequest, 
BodyHandlers.ofInputStream());
@@ -97,7 +94,7 @@ public final class JavaHttpTransport implements HttpTransport 
{
        // Internal helpers
        // 
-----------------------------------------------------------------------------------------------------------------
 
-       private static HttpRequest buildJdkRequest(TransportRequest request) 
throws IOException {
+       private static HttpRequest buildJdkRequest(TransportRequest request) {
                var builder = 
HttpRequest.newBuilder().uri(request.getUri()).method(request.getMethod(), 
buildBodyPublisher(request.getBody()));
                for (var h : request.getHeaders())
                        builder.header(h.name(), h.value());
@@ -107,7 +104,7 @@ public final class JavaHttpTransport implements 
HttpTransport {
        @SuppressWarnings({
                "java:S2095" // PipedInputStream closed by HttpClient when body 
publishing finishes; PipedOutputStream closed in writer thread 
try-with-resources
        })
-       private static BodyPublisher buildBodyPublisher(TransportBody body) 
throws IOException {
+       private static BodyPublisher buildBodyPublisher(TransportBody body) {
                if (body == null)
                        return BodyPublishers.noBody();
                // Use a pipe so body.writeTo() streams directly to the JDK 
client without full in-memory buffering.
@@ -139,6 +136,7 @@ public final class JavaHttpTransport implements 
HttpTransport {
                });
        }
 
+       @SuppressWarnings("resource")
        private static TransportResponse 
buildTransportResponse(HttpResponse<InputStream> jdkResponse) {
                var builder = TransportResponse.builder()
                        .statusCode(jdkResponse.statusCode())
diff --git 
a/juneau-rest/juneau-rest-client/src/main/java/org/apache/juneau/rest/client/JavaHttpTransportBuilder.java
 
b/juneau-rest/juneau-rest-client/src/main/java/org/apache/juneau/rest/client/JavaHttpTransportBuilder.java
index d72d354b13..eec03dd610 100644
--- 
a/juneau-rest/juneau-rest-client/src/main/java/org/apache/juneau/rest/client/JavaHttpTransportBuilder.java
+++ 
b/juneau-rest/juneau-rest-client/src/main/java/org/apache/juneau/rest/client/JavaHttpTransportBuilder.java
@@ -55,6 +55,7 @@ public final class JavaHttpTransportBuilder {
         *
         * @return A new instance. Never <jk>null</jk>.
         */
+       @SuppressWarnings("resource")
        public JavaHttpTransport build() {
                return new JavaHttpTransport(this);
        }
diff --git 
a/juneau-rest/juneau-rest-client/src/main/java/org/apache/juneau/rest/client/JavaHttpTransportProvider.java
 
b/juneau-rest/juneau-rest-client/src/main/java/org/apache/juneau/rest/client/JavaHttpTransportProvider.java
index 16d25a8afe..a1702f3513 100644
--- 
a/juneau-rest/juneau-rest-client/src/main/java/org/apache/juneau/rest/client/JavaHttpTransportProvider.java
+++ 
b/juneau-rest/juneau-rest-client/src/main/java/org/apache/juneau/rest/client/JavaHttpTransportProvider.java
@@ -49,6 +49,7 @@ public final class JavaHttpTransportProvider implements 
HttpTransportProvider {
        }
 
        @Override /* HttpTransportProvider */
+       @SuppressWarnings("resource")
        public HttpTransport create() {
                return JavaHttpTransport.create();
        }