This is an automated email from the ASF dual-hosted git repository.
jamesbognar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/juneau.git
The following commit(s) were added to refs/heads/master by this push:
new 9a752c58be Parquet fix
9a752c58be is described below
commit 9a752c58beb3d370637fef67b1888669b74f53ac
Author: James Bognar <[email protected]>
AuthorDate: Wed Mar 18 19:19:19 2026 -0400
Parquet fix
---
.../juneau/a/rttests/RoundTripTest_Base.java | 24 ++++++----------------
1 file changed, 6 insertions(+), 18 deletions(-)
diff --git
a/juneau-utest/src/test/java/org/apache/juneau/a/rttests/RoundTripTest_Base.java
b/juneau-utest/src/test/java/org/apache/juneau/a/rttests/RoundTripTest_Base.java
index 3f80b93ab6..58657a395f 100644
---
a/juneau-utest/src/test/java/org/apache/juneau/a/rttests/RoundTripTest_Base.java
+++
b/juneau-utest/src/test/java/org/apache/juneau/a/rttests/RoundTripTest_Base.java
@@ -169,16 +169,13 @@ public abstract class RoundTripTest_Base extends TestBase
{
.serializer(ParquetSerializer.create().addBeanTypes())
.parser(ParquetParser.create())
// TODO: Revisit skip conditions as Parquet support
improves:
- // - Null-key maps: root unwrap path with <NULL>
placeholder
// - JsonList/JsonMap: static schema vs mixed types
- // - 2.2: Optional, enum arrays, @Beanc, primitive
arrays
- .skipIf(o -> o == null || o instanceof Class
- || o instanceof JsonList || o instanceof JsonMap
- || (o instanceof Map<?,?> m && mapHasNullKey(m))
- || (isParquetIncompatibleBeanOrCollection(o)
- || (o.getClass().isArray()
- &&
(o.getClass().getComponentType() == Class.class
- ||
o.getClass().getComponentType().isArray())))) // 2D arrays still excluded
+ // TODO: Revisit skip conditions as Parquet support
improves:
+ // - JsonList/JsonMap: static schema vs mixed types
+ // - 2D arrays: Parquet has no nested array support
+ .skipIf(o -> o instanceof JsonList || o instanceof
JsonMap
+ || (o != null &&
isParquetIncompatibleBeanOrCollection(o))
+ || (o != null && o.getClass().isArray() &&
o.getClass().getComponentType().isArray()))
.build(),
};
@@ -190,15 +187,6 @@ public abstract class RoundTripTest_Base extends TestBase {
return RoundTrip_Tester.create(index, label);
}
- /** Returns true if the map contains a null key. TreeMap throws NPE on
containsKey(null). */
- private static boolean mapHasNullKey(Map<?,?> m) {
- try {
- return m.containsKey(null);
- } catch (NullPointerException e) {
- return false;
- }
- }
-
/**
* Returns true if the object contains structures Parquet cannot
serialize
* (nested lists, Optional, parent/child loops, etc.).