fuweng11 commented on code in PR #11986:
URL: https://github.com/apache/inlong/pull/11986#discussion_r2327642815
##########
inlong-audit/audit-tool/src/main/java/org/apache/inlong/audit/tool/manager/ManagerClient.java:
##########
@@ -0,0 +1,105 @@
+package org.apache.inlong.audit.tool.manager;
+
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import org.apache.inlong.audit.tool.config.AppConfig;
+import org.apache.inlong.audit.tool.config.AlertPolicy;
+import org.apache.inlong.audit.tool.reporter.PrometheusReporter;
+import org.apache.inlong.audit.tool.reporter.OpenTelemetryReporter;
+import org.apache.inlong.audit.tool.DTO.AuditData;
+import org.apache.inlong.audit.tool.util.CommonBeanUtils;
+import org.apache.inlong.audit.tool.util.HttpUtils;
+//import org.apache.inlong.manager.pojo.audit.*;
+import org.apache.inlong.audit.tool.response.Response;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.core.ParameterizedTypeReference;
+//import org.springframework.http.HttpMethod;
+import org.springframework.stereotype.Service;
+//import org.springframework.web.client.RestTemplate;
+
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+
+import java.util.stream.Collectors;
+
+@Service
+public class ManagerClient {
+
+// private final AppConfig appConfig;
+// private final PrometheusReporter prometheusReporter;
+// private final OpenTelemetryReporter openTelemetryReporter;
+ private static final Logger LOGGER =
LoggerFactory.getLogger(ManagerClient.class);
+// @Autowired
+// private RestTemplate restTemplate;
+
+// public ManagerClient(AppConfig appConfig) {
Review Comment:
Please do not comment on valid code, and delete invalid code.
##########
inlong-audit/audit-tool/src/main/java/org/apache/inlong/audit/tool/evaluator/AlertEvaluator.java:
##########
@@ -0,0 +1,107 @@
+package org.apache.inlong.audit.tool.evaluator;
+
+import org.apache.inlong.audit.tool.config.AlertPolicy;
+import org.apache.inlong.audit.tool.config.AppConfig;
+import org.apache.inlong.audit.tool.manager.ManagerClient;
+import org.apache.inlong.audit.tool.DTO.AuditData;
+import org.apache.inlong.audit.tool.DTO.MetricData;
+import org.apache.inlong.audit.tool.reporter.PrometheusReporter;
+import org.apache.inlong.audit.tool.reporter.OpenTelemetryReporter;
+
+import java.util.ArrayList;
+import java.util.List;
+
+public class AlertEvaluator {
+ private final PrometheusReporter prometheusReporter;
+ private final OpenTelemetryReporter openTelemetryReporter;
+ private AuditData auditData;
+ private AlertPolicy policy;
+ private ManagerClient managerClient;
+
+ public AlertEvaluator(PrometheusReporter prometheusReporter,
OpenTelemetryReporter openTelemetryReporter, AppConfig appConfig) {
+ this.prometheusReporter = prometheusReporter;
+ this.openTelemetryReporter = openTelemetryReporter;
+ // 需要创建ManagerClient实例
+ //this.managerClient = new ManagerClient(appConfig); //
实际使用时应传入正确的AppConfig
+ }
+
+ private MetricData calculateMetricData(AuditData auditData) {
+ return new MetricData(auditData.getGroupId(), auditData.getStreamId(),
auditData.getDataLossRate(),
+ auditData.getDataLossCount(), auditData.getAuditCount(),
auditData.getExpectedCount(),
+ auditData.getReceivedCount());
+ }
+
+ public List<String> getEnabledPlatforms(AlertPolicy policy) {
+ List<String> enabledPlatforms = new ArrayList<>();
+ List<String> targets = policy.getTargets();
+ if (targets != null) {
+ for (String target : targets) {
+ if ("prometheus".equalsIgnoreCase(target)) {
+ enabledPlatforms.add("prometheus");
+ } else if ("opentelemetry".equalsIgnoreCase(target)) {
+ enabledPlatforms.add("opentelemetry");
+ }
+ }
+ }
+ return enabledPlatforms;
+ }
+
+ public boolean shouldTriggerAlert(AuditData auditData, AlertPolicy policy)
{
+ this.auditData = auditData;
+ this.policy = policy;
+ // 实现具体的告警判断逻辑
+ double dataLossRate = auditData.getDataLossRate();
+
+ // 获取阈值
+ double threshold = policy.getThreshold();
+ String comparisonOperator = policy.getComparisonOperator();
+
+ // 根据比较操作符判断是否触发告警
+ switch (comparisonOperator) {
+ case ">":
+ return dataLossRate > threshold;
+ case ">=":
+ return dataLossRate >= threshold;
+ case "<":
+ return dataLossRate < threshold;
+ case "<=":
+ return dataLossRate <= threshold;
+ case "==":
+ return dataLossRate == threshold;
+ case "!=":
+ return dataLossRate != threshold;
+ default:
+ return false;
+ }
+ }
+
+ public void triggerAlert(AuditData auditData, AlertPolicy policy) {
+ this.auditData = auditData;
+ this.policy = policy;
+ List<String> enabledPlatforms = getEnabledPlatforms(policy);
+
+ // 假设 metricData 是从 auditData 中提取的某种指标数据
Review Comment:
Ditto.
##########
inlong-audit/audit-tool/src/main/java/org/apache/inlong/audit/tool/evaluator/AlertEvaluator.java:
##########
@@ -0,0 +1,107 @@
+package org.apache.inlong.audit.tool.evaluator;
+
+import org.apache.inlong.audit.tool.config.AlertPolicy;
+import org.apache.inlong.audit.tool.config.AppConfig;
+import org.apache.inlong.audit.tool.manager.ManagerClient;
+import org.apache.inlong.audit.tool.DTO.AuditData;
+import org.apache.inlong.audit.tool.DTO.MetricData;
+import org.apache.inlong.audit.tool.reporter.PrometheusReporter;
+import org.apache.inlong.audit.tool.reporter.OpenTelemetryReporter;
+
+import java.util.ArrayList;
+import java.util.List;
+
+public class AlertEvaluator {
+ private final PrometheusReporter prometheusReporter;
+ private final OpenTelemetryReporter openTelemetryReporter;
+ private AuditData auditData;
+ private AlertPolicy policy;
+ private ManagerClient managerClient;
+
+ public AlertEvaluator(PrometheusReporter prometheusReporter,
OpenTelemetryReporter openTelemetryReporter, AppConfig appConfig) {
+ this.prometheusReporter = prometheusReporter;
+ this.openTelemetryReporter = openTelemetryReporter;
+ // 需要创建ManagerClient实例
+ //this.managerClient = new ManagerClient(appConfig); //
实际使用时应传入正确的AppConfig
+ }
+
+ private MetricData calculateMetricData(AuditData auditData) {
+ return new MetricData(auditData.getGroupId(), auditData.getStreamId(),
auditData.getDataLossRate(),
+ auditData.getDataLossCount(), auditData.getAuditCount(),
auditData.getExpectedCount(),
+ auditData.getReceivedCount());
+ }
+
+ public List<String> getEnabledPlatforms(AlertPolicy policy) {
+ List<String> enabledPlatforms = new ArrayList<>();
+ List<String> targets = policy.getTargets();
+ if (targets != null) {
+ for (String target : targets) {
+ if ("prometheus".equalsIgnoreCase(target)) {
+ enabledPlatforms.add("prometheus");
+ } else if ("opentelemetry".equalsIgnoreCase(target)) {
+ enabledPlatforms.add("opentelemetry");
+ }
+ }
+ }
+ return enabledPlatforms;
+ }
+
+ public boolean shouldTriggerAlert(AuditData auditData, AlertPolicy policy)
{
+ this.auditData = auditData;
+ this.policy = policy;
+ // 实现具体的告警判断逻辑
+ double dataLossRate = auditData.getDataLossRate();
+
+ // 获取阈值
+ double threshold = policy.getThreshold();
+ String comparisonOperator = policy.getComparisonOperator();
+
+ // 根据比较操作符判断是否触发告警
Review Comment:
Please avoid using Chinese characters in the code and use English comments
instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
