Re: [PR] [INLONG-11803][Sort] Solve the NPE problem when parsing InLongMsg [inlong]

[via GitHub]

luchunliang commented on code in PR #11804:
URL: https://github.com/apache/inlong/pull/11804#discussion_r1998155984


##########
inlong-sort/sort-formats/format-rowdata/format-inlongmsg-rowdata-base/src/main/java/org/apache/inlong/sort/formats/inlongmsg/AbstractInLongMsgFormatDeserializer.java:
##########
@@ -81,6 +88,21 @@ public List<InLongMsgWrap> preParse(byte[] bytes) throws 
Exception {
         final List<InLongMsgWrap> result = new ArrayList<>();
 
         InLongMsg inLongMsg = InLongMsg.parseFrom(bytes);
+        if (inLongMsg == null) {
+            failureHandler.onParsingMsgFailure(bytes, new IOException(
+                    String.format("Could not parse InLongMsg from bytes. 
bytes={}.",
+                            StringUtils.join(bytes))));

Review Comment:
   
![image](https://github.com/user-attachments/assets/a548da81-1918-48d6-b3a8-28df561f0463)
   It is bad operation.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org