baomingyu commented on code in PR #11547:
URL: https://github.com/apache/inlong/pull/11547#discussion_r1858097984
##########
inlong-sdk/dirty-data-sdk/src/main/java/org/apache/inlong/sdk/dirtydata/InlongSdkDirtySender.java:
##########
@@ -75,7 +74,15 @@ public void init() throws Exception {
}
public void sendDirtyMessage(DirtyMessageWrapper messageWrapper) throws
InterruptedException {
- dirtyDataQueue.offer(messageWrapper, 10, TimeUnit.SECONDS);
+ dirtyDataQueue.put(messageWrapper);
+ }
+
+ public boolean sendDirtyMessageAsync(DirtyMessageWrapper messageWrapper) {
+ boolean result = dirtyDataQueue.offer(messageWrapper);
+ if (!result) {
+ log.warn("send dirty message async queue is full, you can increase
maxCallbackSize");
+ }
Review Comment:
need control the frequency of log outputs
##########
inlong-sdk/dirty-data-sdk/src/main/java/org/apache/inlong/sdk/dirtydata/InlongSdkDirtySender.java:
##########
@@ -75,7 +74,15 @@ public void init() throws Exception {
}
public void sendDirtyMessage(DirtyMessageWrapper messageWrapper) throws
InterruptedException {
- dirtyDataQueue.offer(messageWrapper, 10, TimeUnit.SECONDS);
+ dirtyDataQueue.put(messageWrapper);
+ }
Review Comment:
this function may block the main process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
