PeterZh6 commented on code in PR #11130:
URL: https://github.com/apache/inlong/pull/11130#discussion_r1771319816


##########
inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/postgres-cdc/src/main/java/org/apache/inlong/sort/postgre/RowDataDebeziumDeserializeSchema.java:
##########
@@ -101,6 +102,9 @@ public interface ValueValidator extends Serializable {
     /** Changelog Mode to use for encoding changes in Flink internal data 
structure. */
     private final DebeziumChangelogMode changelogMode;
     private final MetricOption metricOption;
+
+    // Getter to make sourceExactlyMetric accessible to DebeziumSourceFunction
+    @Getter

Review Comment:
   Thanks for pointing this out! I used `@Setter` (not `@Getter`, as mentioned 
in the review) because Lombok is already used in other parts of InLong, and it 
seemed consistent with the existing codebase. However, I understand your 
suggestion and will update the code to use a method instead, based on your 
advice. It seems like there was a mix-up in the annotation, as the current 
version actually uses `@Setter`, not `@Getter`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to