aloyszhang commented on code in PR #10916:
URL: https://github.com/apache/inlong/pull/10916#discussion_r1734072686
##########
inlong-manager/manager-plugins/base/src/main/java/org/apache/inlong/manager/plugin/flink/enums/Constants.java:
##########
@@ -43,6 +43,10 @@ public class Constants {
public static final String FLINK_VERSION = "flink.version";
+ public static final String FLINK_MAXPERCORE = "flink.maxpercore";
+
+ public static final String FLINK_DYNAMIC_PARALLELISM =
"flink.dynamicParallelism";
Review Comment:
rename the variables' name according to `flink-sort-plugin.properties`
##########
inlong-manager/manager-plugins/base/src/main/java/org/apache/inlong/manager/plugin/flink/dto/FlinkConfig.java:
##########
@@ -40,4 +40,8 @@ public class FlinkConfig {
// flink version
private String version;
+ private Integer maxpercore;
+
+ // whether to enable dynamic parallelism
+ private Boolean dynamicParallelism;
Review Comment:
rename the variables' name according to `flink-sort-plugin.properties`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
