fuweng11 commented on code in PR #10755:
URL: https://github.com/apache/inlong/pull/10755#discussion_r1705381599
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/group/InlongGroupServiceImpl.java:
##########
@@ -221,6 +222,20 @@ public String save(InlongGroupRequest request, String
operator) {
// save schedule info for offline group
if (DATASYNC_OFFLINE_MODE.equals(request.getInlongGroupMode())) {
+ Timestamp startTime = request.getStartTime();
+ Timestamp endTime = request.getEndTime();
+ if (startTime == null || endTime == null) {
+ LOGGER.error("start time or end time cannot be empty for
groupId={}", groupId);
+ throw new BusinessException("start time or end time cannot be
empty");
+ }
Review Comment:
```suggestion
Preconditions.expectTrue(startTime != null && endTime != null,
"start time or end time cannot be empty");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
