aloyszhang commented on code in PR #10737: URL: https://github.com/apache/inlong/pull/10737#discussion_r1696710092
########## inlong-sdk/dataproxy-sdk-twins/dataproxy-sdk-python/build.sh: ########## @@ -20,6 +20,12 @@ BASE_DIR=$(pwd) +# Check if dataproxy-sdk-cpp directory exists in the parent directory +if [ ! -d "../dataproxy-sdk-cpp" ]; then Review Comment: Plz do not use the relative path ########## inlong-sdk/dataproxy-sdk-twins/dataproxy-sdk-python/build.sh: ########## @@ -45,14 +51,17 @@ cmake --build . --config Release --target check make check -j 4 cd $BASE_DIR -# Clone and build dataproxy-sdk-cpp -git clone https://github.com/apache/inlong.git -mv ./inlong/inlong-sdk/dataproxy-sdk-twins/dataproxy-sdk-cpp ./ -rm -r ./inlong -cd ./dataproxy-sdk-cpp -chmod +x ./build.sh -./build.sh -cd $BASE_DIR +# Build dataproxy-sdk-cpp(If the dataproxy-sdk-cpp has been compiled, this step will be skipped) +if [ ! -e "../dataproxy-sdk-cpp/release/lib/libdataproxy_sdk.a" ]; then Review Comment: ditto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
