aloyszhang commented on code in PR #10717:
URL: https://github.com/apache/inlong/pull/10717#discussion_r1689524909
##########
inlong-sdk/transform-sdk/src/main/java/org/apache/inlong/sdk/transform/pojo/CsvSourceInfo.java:
##########
@@ -28,17 +29,18 @@
* CsvSourceInfo
*/
@JsonIgnoreProperties(ignoreUnknown = true)
+@SuperBuilder
public class CsvSourceInfo extends SourceInfo {
- private String delimiter;
- private String escapeChar;
+ private Character delimiter;
+ private Character escapeChar;
Review Comment:
Why change the type to `Character`, what if the delimiter is not a
`Character` like `\r\n`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
