XiaoYou201 commented on code in PR #10156:
URL: https://github.com/apache/inlong/pull/10156#discussion_r1593887401
##########
inlong-sort/sort-flink/base/src/main/java/org/apache/inlong/sort/base/metric/MetricOption.java:
##########
@@ -57,54 +57,26 @@ public class MetricOption implements Serializable {
private List<Integer> inlongAuditKeys;
private MetricOption(
- String inlongLabels,
+ Map<String, String> labels,
@Nullable String inlongAudit,
RegisteredMetric registeredMetric,
long initRecords,
long initBytes,
Long initDirtyRecords,
Long initDirtyBytes,
Long readPhase,
- String inlongAuditKeys) {
-
Preconditions.checkArgument(!StringUtils.isNullOrWhitespaceOnly(inlongLabels),
- "Inlong labels must be set for register metric.");
-
+ List<Integer> inlongAuditKeys,
+ HashSet<String> ipPortList) {
Review Comment:
Renamed and refactor the hashSet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
