EMsnap commented on code in PR #10146: URL: https://github.com/apache/inlong/pull/10146#discussion_r1593489726
########## inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/redis/src/main/java/org/apache/inlong/sort/redis/source/RedisRowDataLookupFunction.java: ########## @@ -107,6 +120,10 @@ public void eval(Object... keys) { throw new UnsupportedOperationException( String.format("Unsupported for redisCommand: %s", redisCommand)); } + if (sourceMetricData != null) { + sourceMetricData.outputMetricsWithEstimate(rowData, System.currentTimeMillis()); Review Comment: no need to get current time here see private long getCurrentOrProvidedTime(long dataTime) { return dataTime == 0 ? System.currentTimeMillis() : dataTime; } -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org