aloyszhang commented on code in PR #10062:
URL: https://github.com/apache/inlong/pull/10062#discussion_r1577411551
##########
inlong-agent/agent-installer/src/main/java/org/apache/inlong/agent/installer/ModuleManager.java:
##########
@@ -461,7 +462,7 @@ private boolean downloadModule(ModuleConfig module) {
private boolean isPackageDownloaded(ModuleConfig module) {
String path = module.getPackageConfig().getStoragePath() + "/" +
module.getPackageConfig().getFileName();
String fileMd5 = calcFileMd5(path);
- if (fileMd5.equals(module.getPackageConfig().getMd5())) {
+ if (Objects.equals(fileMd5, module.getPackageConfig().getMd5())) {
Review Comment:
what if both`fileMd5` and `module.getPackageConfig().getMd5()` are null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
