EMsnap commented on code in PR #9973:
URL: https://github.com/apache/inlong/pull/9973#discussion_r1560978457
##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/node/extract/PulsarExtractNode.java:
##########
@@ -107,23 +129,27 @@ public PulsarExtractNode(@JsonProperty("id") String id,
@Override
public Map<String, String> tableOptions() {
Map<String, String> options = super.tableOptions();
- if (StringUtils.isEmpty(this.primaryKey)) {
+ if (StringUtils.isBlank(this.primaryKey)) {
options.put("connector", "pulsar-inlong");
options.putAll(format.generateOptions(false));
} else {
options.put("connector", "upsert-pulsar-inlong");
options.putAll(format.generateOptions(true));
}
- if (adminUrl != null) {
+ if (StringUtils.isNotBlank(adminUrl)) {
options.put("admin-url", adminUrl);
}
options.put("service-url", serviceUrl);
options.put("topic", topic);
options.put("scan.startup.mode", scanStartupMode);
- if (scanStartupSubName != null) {
+ if (StringUtils.isNotBlank(scanStartupSubName)) {
options.put("scan.startup.sub-name", scanStartupSubName);
options.put("scan.startup.sub-start-offset",
scanStartupSubStartOffset);
}
+ if (StringUtils.isNotBlank(clientAuthPluginClassName)) {
+ options.put("pulsar.client.authPluginClassName",
clientAuthPluginClassName);
+ options.put("pulsar.client.authParams", clientAuthParams);
Review Comment:
fixed thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
