aloyszhang commented on code in PR #9805:
URL: https://github.com/apache/inlong/pull/9805#discussion_r1522391284
##########
inlong-agent/agent-common/src/main/java/org/apache/inlong/agent/constant/TaskConstants.java:
##########
@@ -117,6 +117,14 @@ public class TaskConstants extends CommonConstants {
public static final String JOB_KAFKA_READ_TIMEOUT =
"job.kafkaJob.read.timeout";
public static final String TASK_KAFKA_AUTO_COMMIT_OFFSET_RESET =
"task.kafkaJob.autoOffsetReset";
+ // Pulsar task
+ public static final String TASK_PULSAR_TENANT = "task.pulsarTask.tenant";
+ public static final String TASK_PULSAR_NAMESPACE =
"task.pulsarTask.namespace";
+ public static final String TASK_PULSAR_TOPIC = "task.pulsarTask.topic";
+ public static final String TASK_PULSAR_SERVICE_URL =
"task.pulsarTask.serviceUrl";
+ public static final String TASK_PULSAR_SCAN_STARTUP_MODE =
"task.pulsarTask.scanStartupMode";
+ public static final String TASK_PULSAR_RESET_TIME =
"task.pulsarTask.resetTime";
+
Review Comment:
Currently, we have `Binlog job` and `Kafka job`, is it better for us to add
a new type called `Pulsar job` instead of `Pulsar task`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
